-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix, chore, perf, style, feat, improv, refactor, test, docs: update dispatcher.h/.cpp #899
Conversation
Thank you for your contribution, but PRs must be raised against the |
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
squeaky clean new code, when can we merge it 😄
now plz, with a release too if possible <3 |
When I fix ARM 😭 |
your new unit test fails |
This PR allows events to be move and copy assigned.
That's it. Definitely nothing else in 800 line changes.
Just kidding :
stop_event
for event cancellation into a mutable bool inside of event_dispatch_t (yes, it still works)message_create_t::send
taking with a non-const lvalue reference to dpp::messageAPI remains the same for everything
Code change checklist